Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: add new ImportEpoch DeleteRangePredicate #120048

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

stevendanna
Copy link
Collaborator

When set, MVCCDeleteRangePredicate will delete any values with
ImportEpoch's in their MVCCValueHeader that is >= the given
ImportEpoch predicate.

Release note: none
Epic: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@stevendanna stevendanna force-pushed the import-epoch-predicate branch from 29f210d to b1d06f5 Compare March 12, 2024 20:18
@stevendanna stevendanna marked this pull request as ready for review March 12, 2024 20:20
@stevendanna stevendanna requested review from a team as code owners March 12, 2024 20:20
@stevendanna stevendanna requested review from sumeerbhola, itsbilal, dt and msbutler and removed request for sumeerbhola, a team and dt March 12, 2024 20:20
Copy link
Collaborator

@msbutler msbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we'll get this in before branch cut!

pkg/storage/mvcc.go Show resolved Hide resolved
pkg/storage/mvcc.go Show resolved Hide resolved
#
# Import 1 from t [1,2]
# More writes at t3
# Import 2 from t [4,g]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/g/5/r

pkg/kv/kvpb/api.proto Show resolved Hide resolved
@stevendanna stevendanna force-pushed the import-epoch-predicate branch from b1d06f5 to 1a1f256 Compare March 13, 2024 21:43
When set, MVCCDeleteRangePredicate will delete any values with
ImportEpoch's in their MVCCValueHeader that is >= the given
ImportEpoch predicate.

Release note: none
Epic: None
@stevendanna stevendanna force-pushed the import-epoch-predicate branch from 1a1f256 to bf282fc Compare March 13, 2024 21:48
Copy link
Collaborator

@msbutler msbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pkg/storage/mvcc.go Show resolved Hide resolved
@stevendanna
Copy link
Collaborator Author

bors r=msbutler

@craig
Copy link
Contributor

craig bot commented Mar 15, 2024

@craig craig bot merged commit e8fda58 into cockroachdb:master Mar 15, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants